Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bend: 0.2.9 -> 0.2.22, hvm: 2.0.12 -> 2.0.17 #314965

Merged
merged 2 commits into from
May 29, 2024

Conversation

jeremyschlatter
Copy link
Contributor

@jeremyschlatter jeremyschlatter commented May 26, 2024

Description of changes

Bend is tightly coupled to hvm, so I am submitting both updates at the same time. If one is merged without the other, bend will fail to build.

Drops RUSTC_BOOTSTRAP = true for both packages. Bend no longer requires rust nightly, and it turns out hvm v2 never did.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

HVM2 never needed rust nightly, so also drop `RUSTC_BOOSTRAP = true`.

See HigherOrderCO/HVM#352
Bend no longer needs nightly, so drop `RUSTC_BOOTSTRAP = true`.

See HigherOrderCO/Bend#486

Also drop `fetchCrate`, which was unused.
@k3yss
Copy link
Contributor

k3yss commented May 27, 2024

Result of nixpkgs-review pr 314965 run on x86_64-linux 1

2 packages built:
  • bend
  • hvm

@wegank wegank merged commit 472340f into NixOS:master May 29, 2024
30 checks passed
@jeremyschlatter jeremyschlatter deleted the bend-0-2-22_hvm-2-0-17 branch May 29, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants